Fixed warning of incorrect migrations path on builds (#209) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doekenorg is this PR related to this issue: #209 ? |
Yeah sorry, forgot to add that to the comment. But it is. You can also check the branch name; that usually has the issue ID in front of it ( |
doekenorg
changed the title
mrcasual
approved these changes
Jan 16, 2025
|
The user confirmed the fix, we can release! @mrcasual |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we moved the plugin over to Strauss the
Migrationswere also moved tovendor_prefixed, while the container was still configured to the old<plugin>/src/..folder. Since the builds no longer have this folder, it caused a warning.This PR resolves that issue (#209) by adding a
is_readablecheck on the folder, and a change of folder-root (GFEXCEL_SRC_FOLDER) when it concerns a build.It also fixed a tiny "bug" where, when a migration fails for an unrecoverable reason, the migration state is reset from
running. This will make it possible for a migration to try again sooner.💾 Build file (acaf95c).